Skip to content

Fix some lints introduced in a recent PR. #35193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liferoad merged 1 commit into from
Jun 6, 2025
Merged

Fix some lints introduced in a recent PR. #35193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/go/pkg/beam/runners/dataflow/dataflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,8 +475,8 @@ func checkSoftDeletePolicyEnabled(ctx context.Context, bucketName string, locati
}
defer client.Close()

if enabled, err_msg := gcsx.SoftDeletePolicyEnabled(ctx, client, bucket); err_msg != nil {
log.Warnf(ctx, "Error checking SoftDeletePolicy: %v", err_msg)
if enabled, errMsg := gcsx.SoftDeletePolicyEnabled(ctx, client, bucket); errMsg != nil {
log.Warnf(ctx, "Error checking SoftDeletePolicy: %v", errMsg)
} else if enabled {
log.Warnf(ctx, "Bucket %s specified in %s has soft-delete policy enabled. "+
"Dataflow jobs use Cloud Storage to store temporary files during pipeline execution. "+
Expand Down
Loading