Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] migrate-junit5-client-module #4492

Conversation

sherlock-lin
Copy link
Contributor

@sherlock-lin sherlock-lin commented Aug 27, 2024

Descriptions of the changes in this PR:

Main Issue: #4322

@sherlock-lin sherlock-lin changed the title migrate-junit5-client-module test: migrate-junit5-client-module Aug 27, 2024
@sherlock-lin sherlock-lin changed the title test: migrate-junit5-client-module [Test] migrate-junit5-client-module Aug 27, 2024
@sherlock-lin sherlock-lin force-pushed the sherlock-migrate-junit5-client-moudule-0827 branch from 0e18456 to bf55d26 Compare August 29, 2024 03:01
@liangyuanpeng
Copy link

liangyuanpeng commented Sep 2, 2024

Fix #4322

do not close the issue if it is just a subtask of an issue
Fix #4322 is mean close the issue 4322 when this PR is merged

@sherlock-lin
Copy link
Contributor Author

Fix #4322

do not close the issue if it is just a subtask of an issue Fix #4322 is mean close the issue 4322 when this PR is merged

@liangyuanpeng Thanks, I'll avoid the same mistake in the future

@sherlock-lin sherlock-lin force-pushed the sherlock-migrate-junit5-client-moudule-0827 branch 4 times, most recently from bf55193 to b21e0c5 Compare September 3, 2024 11:48
@sherlock-lin
Copy link
Contributor Author

@shoothzj please help review

Copy link

@xiezhx9 xiezhx9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shoothzj shoothzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it contains too many format code, can we avoid this?

@sherlock-lin
Copy link
Contributor Author

Ok, I'll make some adjustments.

@sherlock-lin sherlock-lin force-pushed the sherlock-migrate-junit5-client-moudule-0827 branch from b21e0c5 to f148f63 Compare October 24, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants