Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

如何关闭 sampler 线程? #1891

Closed
zengshicai2015 opened this issue Aug 17, 2022 · 3 comments
Closed

如何关闭 sampler 线程? #1891

zengshicai2015 opened this issue Aug 17, 2022 · 3 comments
Labels
feature new feature

Comments

@zengshicai2015
Copy link

当前在我们线上场景发现bvar 线程始终是100%在运转的。所以我们在思考,
1,能否彻底关闭bvar 的sampler 线程?从代码来看,当前貌似没有关闭的gflag。
2,关闭了sampler 线程对brpc实际的影响是啥?仅仅是一些统计值看不了吗?如果我们不关心这些统计值的话,是不是就没有影响?
3,能否在后续的迭代版本中增加一个gflag,用来控制是否开启sampler线程?
辛苦帮忙解答一下,谢谢,Thanks♪(・ω・)ノ

@serverglen
Copy link
Contributor

  1. 目前确实没有关闭 sampler的 gflag
  2. 关闭 sampler 线程 会导致 所有的bvar统计值失效,我理解应该不影响brpc和用户的业务逻辑
  3. 可以增加一个gflag控制是否开启sampler线程。

@leaf-potato
Copy link
Contributor

PR: #1990

@serverglen
Copy link
Contributor

已合入,closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

No branches or pull requests

3 participants