Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implementation specific function name of EventDispatcher #1894

Open
zyearn opened this issue Aug 17, 2022 · 3 comments
Open

Remove implementation specific function name of EventDispatcher #1894

zyearn opened this issue Aug 17, 2022 · 3 comments
Labels
good first issue Good for newcomers refactor

Comments

@zyearn
Copy link
Member

zyearn commented Aug 17, 2022 •
edited
Loading

Some of the member functions of EventDispatcher are implementation specific, for example AddEpollOut.

We need to change that specific function name and adopt more general name then we can easily support brpc to more platforms.
@zyearn zyearn mentioned this issue Aug 17, 2022
Merged
@zyearn zyearn added the good first issue Good for newcomers label Aug 17, 2022
@fansehep
Copy link
Contributor

fansehep commented Oct 9, 2022 •
edited
Loading

这里只需改变AddEpollOut 和 RemoveEpollOut 两个函数即可,
AddEpollOut => AddMultiplex
RemoveEpollOut => RemoveMultiplex
这种命名是否是一个合适的做法呢?

@fansehep fansehep mentioned this issue Oct 9, 2022
Open
@Divyansh200102
Copy link
Contributor

I want to work on this issue @zyearn

@Divyansh200102 Divyansh200102 mentioned this issue Dec 4, 2023
Merged
@Divyansh200102
Copy link
Contributor

Please review this pr as well @zyearn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wwbmmm @zyearn @fansehep @Divyansh200102