Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support protobuf 22+ #2537

Closed
Superskyyy opened this issue Feb 6, 2024 · 1 comment · Fixed by #2546
Closed

Support protobuf 22+ #2537

Superskyyy opened this issue Feb 6, 2024 · 1 comment · Fixed by #2546

Comments

@Superskyyy
Copy link
Member

Superskyyy commented Feb 6, 2024

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)
The current bRPC cannot compile with a protobuf runtime v22.0+

Describe the solution you'd like (描述你期望的解决方法)
This issue is mainly due to the backwards-incompatible changes introduced by abseil logging, the current brpc still uses the old logging stubs which are removed by protobuf since v22.0. Not sure if there are other changes needed. https://protobuf.dev/support/migration/#abseil

Describe alternatives you've considered (描述你想到的折衷方案)
Currently I have to downgrade my protobuf used by other dependencies to match bRPC, this is not an ideal solution in the long run. Any help is greatly appreciated.

Additional context/screenshots (更多上下文/截图)

@ketor
Copy link
Contributor

ketor commented Feb 17, 2024

希望可以早日支持protobuf v22.0+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants