Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Camel K operator more involved in the Knative SinkBinding flow #1976

Closed
nicolaferraro opened this issue Feb 1, 2021 · 3 comments
Closed
Labels
Milestone

Comments

@nicolaferraro
Copy link
Member

Currently the operator just delegates SinkBinding to apply changes to the deployment/ksvc/cronjob child resources of an integration. This may result in unexpected errors in deployments/pods when the binding happens late or has an error (because of env vars missing).

It would be good if the operator could put the integration in a "waiting for binding" state (maybe the same used for service-binding, thanks to @johnpoth), then proceed only when the binding is done, to avoid temporary errors.

To do this, we should look into sinkbinding to see if they have a way for external operators to intercept the flow (like service-binding does). Otherwise we may think to (contribute it, or) make the integration podSpecable, so that the SinkBinding is applied to the integration itself, not to the child resources.

@nicolaferraro nicolaferraro added this to the 1.4.0 milestone Feb 1, 2021
@lburgazzoli
Copy link
Contributor

I think we have talked about this in the past already and maybe a new "waiting" state could be useful in general i.e. we may pause an integration than needs a not yet available secret

@nicolaferraro
Copy link
Member Author

I think we have talked about this in the past already and maybe a new "waiting" state could be useful in general i.e. we may pause an integration than needs a not yet available secret

Yeah, same waiting state and multiple conditions seems feasible.

I think SinkBinding can only work on PodSpecable currently.

@astefanutti astefanutti added the area/knative Related to Knative label Feb 2, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.4.0, 1.5.0 Apr 13, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.5.0, 1.6.0 Jul 5, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.6.0, 1.7.0 Sep 7, 2021
@nicolaferraro nicolaferraro modified the milestones: 1.7.0, 1.8.0 Nov 15, 2021
@oscerd oscerd modified the milestones: 1.8.0, 1.9.0 Jan 19, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@oscerd oscerd modified the milestones: 1.9.0, 1.9.1 Apr 26, 2022
@oscerd oscerd modified the milestones: 1.9.1, 1.9.2 May 13, 2022
@oscerd oscerd modified the milestones: 1.9.2, 2.0.0 May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants