-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log a warn message once the component used has not a quarkus extension #3127
Comments
Hey @aboucham, I would like to work on this issue, although I am a beginner, this seems like a fairly simpler solution to work around. |
Just assigned to you. Please, let us know if you need any help. |
yes, it would be great if you can share some resources to refer, sort of code walkthroughs or any resource that shall be useful in giving a headstart. |
I think some possible way to fix it is to scan the log provided from the builder. However, I'm just noticing a more general scenario could be covered by #3149. @phantomjinx can you please confirm that with the work you're doing that you are covering also the error mentioned in this issue? |
Thanks @phantomjinx. I was trying to think a simple approach to parse the log, capture the kind of error and bubble up into the Builder error conditions. However, for the sake of simplicity, I think we can start inspecting the content of the maven log line here, and if it complains of a camel dependency missing a version (such as in the issue description) we can add an additional line of log explaining that likely, the component has not a Camel Quarkus extension valid. @parul5sahoo I hope that can give you some hint on how to proceed. |
Can't we verify the validity of any requested camel artifacts by attempting to look them up in the catalog, instead of parsing logs? |
Yeah, it's a very good idea. Probably we can extend the functions in https://github.com/apache/camel-k/blob/main/pkg/util/camel/camel_dependencies.go to lookup into the catalog, otherwise returning an error. If we go through this path, I am not sure if it's still suitable as a "good first issue" for contributors as it requires a bit of knowledge of the project. |
Incase the issue would need a bit of investing, I would like to collaborate on this issue with an experienced collaborator if that's possible.. |
Don't worry. Please, look for some other issue that you'd like to work on. I'm unassigning for now. |
This issue has been automatically marked as stale due to 90 days of inactivity. |
It's still a nice-to-have and shouldn't be stale. |
Log a warn message once the component used has not a quarkus extension.
For the moment, we see only the following lines in the operator log:
The text was updated successfully, but these errors were encountered: