Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in startup probes to the Health trait #4146

Closed
mertdotcc opened this issue Mar 20, 2023 · 3 comments · Fixed by #4305
Closed

Bring in startup probes to the Health trait #4146

mertdotcc opened this issue Mar 20, 2023 · 3 comments · Fixed by #4305
Assignees
Labels
area/traits kind/feature New feature or request

Comments

@mertdotcc
Copy link
Contributor

mertdotcc commented Mar 20, 2023

For some applications with long startup times, having the liveness and readiness probes set up to a specific value might be problematic as our application is not necessarily not ready yet, as it is still starting up. Kubernetes recently introduced the Startup Probes so that we can have the ability to temporarily disable the liveness and readiness checks until the startup probe succeeds.

I am aware that there is probably not an urgent need for this (also indicated by the non-existence of other issues regarding the lack of startup probes support) since most Camel-K integrations have super fast startup times; but having recently worked on a couple of integrations with quite decent startup times, I feel like ... why not? Let's add 'em.

Open to discussions, thanks in advance!

@squakez squakez added kind/feature New feature or request area/traits labels Mar 21, 2023
@mertdotcc
Copy link
Contributor Author

@squakez If you agree that this is worth adding to Camel-K, I would like to volunteer and take over this. I might need some help here and there though, as this would be my first contribution to the project (outside of some documentation-related commits). But I have been meaning to start contributing to this project, which I use almost every day; and I feel like this would make a nice entry point for me to get started.

@squakez
Copy link
Contributor

squakez commented Mar 21, 2023

Fantastic! We'll be more than happy to help you getting through it. Typically trait development is a very good way to start contributing at the project as you only focus on a specific aspect of the development. I'm assigning this to you and feel free to ping me through this issue or any PR you'll be submitting in order to help you sort out any problem. Also Apache Mailing list is a good way of communicating and Zulip chat (ping me directly as I may miss some thread otherwise).

@mertdotcc
Copy link
Contributor Author

Alright! Sounds good, thanks @squakez!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/traits kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants