Fixes apache#7004: making azure-key-valt refresh test stable. #7009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Feb 14, 2025
aldettinger
reviewed
Feb 14, 2025
| } | ||
|
|
||
| AzureKeyVaultUtil.deleteSecretImmediately(secretName); | ||
| // following code marks events in the hu as read, which might be handy for developers |
There was a problem hiding this comment.
So finally, those commented lines are not needed anymore ?
There was a problem hiding this comment.
I left some typos fixes un-commited on my file system, so I added them.
Thought the explanation, why the code is there commented, was missing.
I added an explanation . The result is:
// meant to be commented.
// during development, it may be handy to mark eventhub as completely read. (in case the test is not reading all the messages by itself)
// Please uncomment the rest of the code to make cursor reset to the latest position after test execution
// following code moves the cursor of the hub to the latest position, thus marking all events as read
// partition 0 is hardcoded (the resource script creates only one partition)
// by default this functionality should not be executed, as the eventbus might be shared for more tests/purposes
// even if event stays, it is removed by retention policy in some time (i.e. 1 hpr)
Does it makes sense to you?
JiriOndrusek
force-pushed
the
azure-validation
branch
from
c21b8fe to
e83196f
Compare
JiriOndrusek
force-pushed
the
azure-validation
branch
from
e83196f to
9cdc120
Compare
JiriOndrusek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7004
I added a few logging messages, better deletion after the tests (directly via client, delay between registering refresh listeners and sending message and unique message regexp for the context refresh tests.
With this fix, the tests are stable and works in the native.