Skip to content

Commit f03a28d

Browse files
committed
fix(observation): create a generic log event
Instead of a log event for each different log message. Closes CAMEL-21854
1 parent b571dbb commit f03a28d

File tree

1 file changed

+2
-14
lines changed

1 file changed

+2
-14
lines changed

components/camel-observation/src/main/java/org/apache/camel/observation/MicrometerObservationSpanAdapter.java

+2-14
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,9 @@ public void setLowCardinalityTag(String key, Boolean value) {
108108
public void log(Map<String, String> fields) {
109109
String event = fields.get("event");
110110
if ("error".equalsIgnoreCase(event)) {
111-
if (fields.containsKey("message")) {
112-
observation.error(new RuntimeException(fields.get("message")));
113-
} else {
114-
setError(true);
115-
}
111+
setError(true);
116112
} else {
117-
observation.event(() -> getMessageNameFromFields(fields));
113+
observation.event(() -> DEFAULT_EVENT_NAME);
118114
}
119115
}
120116

@@ -139,14 +135,6 @@ public AutoCloseable makeCurrent() {
139135
return observation.openScope();
140136
}
141137

142-
String getMessageNameFromFields(Map<String, ?> fields) {
143-
Object eventValue = fields == null ? null : fields.get("message");
144-
if (eventValue != null) {
145-
return eventValue.toString();
146-
}
147-
return DEFAULT_EVENT_NAME;
148-
}
149-
150138
public void setCorrelationContextItem(String key, String value) {
151139
Baggage baggage = tracer.createBaggage(key);
152140
Span span = getTracingContext().getSpan();

0 commit comments

Comments
 (0)