Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back Button after Full Screen Mode #839

Closed
josephlodero opened this issue Oct 8, 2019 · 7 comments
Closed

Back Button after Full Screen Mode #839

josephlodero opened this issue Oct 8, 2019 · 7 comments

Comments

@josephlodero
Copy link

Bug Report

Problem

Back Button will exit the app after the full screen mode it only happens in API 28 but in API 27 to down is working properly

What is expected to happen?

back button should be go back to main page after the full screen mode

What does actually happen?

after the full screen mode and use the back button it will crash/exit the app

Environment, Platform, Device

Android Device

Version information

cordova 9
cordova-android 8.1.0

@breautek
Copy link
Contributor

breautek commented Oct 8, 2019

Is it possible that you can provide a sample reproduction app that I can use as a test app?

https://github.com/apache/cordova-contribute/blob/master/create-reproduction.md

This would help me focus on debugging. Thanks.

@josephlodero
Copy link
Author

@breautek
https://github.com/josephlodero/cordova-fullscreen

steps:
1: clone
2: npm install
3: cordova platform add android
4 cordova emulate android

Cordova CLI : 9.0.0 (cordova-lib@9.0.1)
Cordova Platforms : android 8.1.0

note: the video is not working due to cross origin but i think it doesnt matter. ther problem is the after the fullscreen mode and then use the platform backbutton

thank you for your help!

@breautek
Copy link
Contributor

Thanks, I'll try to take a look sometime this week.

@breautek
Copy link
Contributor

@josephlodero Sorry, can you create me a non ionic reproduction app? I've never used ionic before nor am I very experienced in the angular framework. Additionally having a pure cordova reproduction app will also help prove that the issue is indeed coming from Cordova and nothing that the ionic frameworks adds/overrides.

@josephlodero
Copy link
Author

@breautek
Hi! try this one : https://github.com/josephlodero/cordovaapp
i just wrapped my angular app to cordova i hope this one will do.
thanks!

@breautek
Copy link
Contributor

breautek commented Nov 1, 2019

Thanks, if I don't make a comment within a week, don't hesitate to ping me, but I'll try to take a look over the weekend.

@breautek
Copy link
Contributor

breautek commented Nov 2, 2019

This is actually the same issue as #822

And there is a pending PR awaiting review that should fix this issue at #823

In the meantime as a workaround, you can fork the cordova-android repo, and pull in that PR to use.

To keep things organised I'm going to close this ticket. Any further discussion on this issue should be done in #822

@breautek breautek closed this as completed Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants