Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release approval criteria #209

Open
brodycj opened this issue Oct 10, 2018 · 3 comments
Open

Release approval criteria #209

brodycj opened this issue Oct 10, 2018 · 3 comments

Comments

@brodycj
Copy link

brodycj commented Oct 10, 2018

I think this is not clear for all members.

@purplecabbage
Copy link
Contributor

There is really nothing more to it than what is listed in the voting guidelines linked from every vote thread.

When we (or at least, members of the PMC), vote on a release, we are expressing confidence that:

Our sources are properly licensed*.
We have only compatibly licensed dependencies (and appropriate NOTICE lines)*.
No IP was added without the consent of its owner**.
Archives are properly signed & hashed.
Repo tags match sha1 stated in vote email.
We believe the quality of the release is better than the previous one.

  • These items are generally checked by the Release Manager. The Release Manager should state that they've checked them when they +1 the vote.

** It is the responsibility of committers to ensure that no invalid IP enters the codebase. It's not something that we need to re-check at each release.

@brodycj
Copy link
Author

brodycj commented Oct 10, 2018 via email

@purplecabbage
Copy link
Contributor

Archives are properly signed & hashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants