Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to run context by default #238

Open
janpio opened this issue May 8, 2019 · 3 comments
Open

Switch to run context by default #238

janpio opened this issue May 8, 2019 · 3 comments

Comments

@janpio
Copy link
Member

janpio commented May 8, 2019

Currently coho runs on the install/checkout location parent of coho (!), not where you execute it. For that to happen, you have to actually use the -g/--global option.

As this is super easy to forget, and the run context is much more expected (even with documentation via #237), we should change this in a major version and, if necessary, add an option to not use the global context if you choose so.

@raphinesse
Copy link
Contributor

IMHO it should target current working directory or an explicitly provided path.

No need for a flag that makes it use it's parent dir.

@brodycj
Copy link

brodycj commented May 16, 2019

IMHO it should target current working directory or an explicitly provided path.

Agreed on my part.

Interesting counterpoint by @purplecabbage in [1]:

Remember that coho has very limited use and
is not really intended for wide adoption. It is for developers working
with the collection of cordova repos, and managing the multitude of repos
that we have.

I just labeled PR #237 as a bug and this one as an enhancement.

I hope we get PR #237 merged for the sake of clarity.

[1] https://lists.apache.org/thread.html/14fa97e3db204b70ac77bf40d0a732745d5c71d16e081c07a04149d0@%3Cdev.cordova.apache.org%3E

@janpio
Copy link
Member Author

janpio commented May 24, 2019

#237 was successfully merged and helps developers to understand what is going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants