Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrongly created exportOptions.plist file - multiple provisioning profile support #953

Closed
3 tasks done
HarelM opened this issue Jul 26, 2020 · 2 comments
Closed
3 tasks done

Comments

@HarelM
Copy link

HarelM commented Jul 26, 2020

Bug Report

When there is more than one target and you are trying to sign both it doesn't work right.
This is partially a bug and partially a feature request.

Problem

What is expected to happen?

I expect to be able to sign two or more targets from CI server

What does actually happen?

I can't do it right now.

Information

This is after reviewing the discussion here:
#820 and #538
and #545 (which I think tried to solve this as well).

Command or Code

I'm building an ios cordova app with a share extension.
I configured a provisioning profile for both the extension and the app
I setup everything up and the build succeeds but the export fails.
I took a look in the exportOptions.plist file and there's only one provisioning profile, somehow the bundle name and provision profile got mixed (bundle id is for the app extension and PP UUID is for the app) which I can't really explain, but in any case it doesn't support multiple PP which is what needed in order to be able to sign the app from a CI server.
Code can be seen here (although it's not straight forward)
https://github.com/IsraelHikingMap/Site/tree/bc641a1b8c6e22293678ebe8e1a214fa2782ef05/IsraelHiking.Web
Relevant build:
https://ci.appveyor.com/project/IsraelHikingHost/site/builds/34309662

Environment, Platform, Device

iOS - Appveyor CI - macOS VM.

Version information

cordova cli 9.0.0
cordova-ios: 6.1.0
macOS VM from appveyor and also my own: 10.15.5

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above

Let me know if this is something on the road map or in implementation, otherwise I can try and see if I can do a PR for this...

@HarelM
Copy link
Author

HarelM commented Jul 27, 2020

I'm splitting this issue into two - a bug report (#955) and a feature request.
I'll keep this thread for the feature request and submit a PR shortly.
Not sure what to do with the bug I found, currently I'm not sure how to fix it and the code I wrote is working around it.
I'll submit s PR for review and we can discuss the details there.

@erisu
Copy link
Member

erisu commented Sep 5, 2022

Resolved in #1251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants