You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The document.addEventListener, document.removeEventListener, window.addEventListener, window.removeEventListener overloads in cordova.js error if the evt variable is undefined. While this is something that also be fixed upstream in the relevant calling code, these functions should not be erroring as that is not the behaviour of what they are overloading.
window.addEventListener(undefined, () => {})
In cordova.js, the above would cause an error.
In safari/chrome console, no error is triggered.
Adding to this, passing an Event instance instead of a string will also throw an exception when trying to get it converted to a lower case string as for example here:
The
document.addEventListener
,document.removeEventListener
,window.addEventListener
,window.removeEventListener
overloads incordova.js
error if theevt
variable is undefined. While this is something that also be fixed upstream in the relevant calling code, these functions should not be erroring as that is not the behaviour of what they are overloading.In cordova.js, the above would cause an error.
In safari/chrome console, no error is triggered.
I have create a PR to address this.
#245
Related:
ionic-team/capacitor#4178
mapbox/mapbox-gl-js#11433
The text was updated successfully, but these errors were encountered: