Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native implementations should not return info.cordova #101

Open
janpio opened this issue May 24, 2019 · 0 comments
Open

native implementations should not return info.cordova #101

janpio opened this issue May 24, 2019 · 0 comments

Comments

@janpio
Copy link
Member

janpio commented May 24, 2019

From the current sourcecode:

// ignoring info.cordova returning from native, we should use value from cordova.version defined in cordova.js
// TODO: CB-5105 native implementations should not return info.cordova

Still present at:

cordova: browser.cordovaVersion,

devProps[@"cordova"] = [[self class] cordovaVersion];

@"cordova": [[self class] cordovaVersion],

(Note: https://issues.apache.org/jira/browse/CB-5105 says "iOS is doing something special, but doing it right, so don't make any changes to iOS." but no idea what that refers to)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant