Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iOs) Device properties request can crash if invoked on locked device #179

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

RSATom
Copy link

@RSATom RSATom commented Jul 26, 2022

Platforms affected

iOs

Motivation and Context

I think it should fix #108

Description

Just replace nil values with empty string since NSDictionary crashes in that case

Testing

Don't sure how to test it, since it's pretty rare case.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@RSATom RSATom changed the title [iOs] Device properties request can crash if invoked on locked device (iOs) Device properties request can crash if invoked on locked device Jul 26, 2022
@RSATom RSATom marked this pull request as draft July 28, 2022 14:26
@RSATom RSATom marked this pull request as ready for review September 5, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS: deviceProperties method crashes when device is locked & data protection is set to "complete"
1 participant