Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable configration for device uuid #176

Open
xuwupeng2000 opened this issue Jul 14, 2022 · 3 comments
Open

Enable configration for device uuid #176

xuwupeng2000 opened this issue Jul 14, 2022 · 3 comments
Milestone

Comments

@xuwupeng2000
Copy link

Feature Request

Motivation Behind Feature

Currently there are rules in China Mainland regarding to how device uuid can be collected and used.
Some of the android distribution shops eg: Huawei shop, disallow collecting device uuid.
And therefore I wonder if we can support configuration to enable/disable device uuid feature.

Thanks

Feature Description

Support configuration to enable/disable device uuid feature

Alternatives or Workarounds

Alternatively we can comment out #GetUuid() method after the native code is built.

@5thgfka
Copy link

5thgfka commented Jul 15, 2022

I comment Device.uuid = getUuid();
public void initialize(CordovaInterface cordova, CordovaWebView webView) { super.initialize(cordova, webView); // Device.uuid = getUuid(); }
and add a setDeviceUuid action to set uuid when user agree.

@breautek breautek added this to the 3.x milestone Jul 15, 2022
@breautek
Copy link
Contributor

Thank you for feature request.

For privacy concerns, I agree this change is necessary. In addition to your use case, not all users of this plugin needs or requires the UUID. Sometimes they just simply want to know the device android version for compatibility checks. So generating/pulling the UUID when it's not required can raise privacy concerns.

Pull requests are welcome, however keep in mind that this request in particular will be a breaking change as it requires not automatically generating/determining UUID on the platform, which means it would require the application to call on the API to generate/get the UUID when it is deemed acceptable to do so. As a result it may take some time before we can incorporate or merge any pull requests for this feature request.

For the breaking change reasons, I've added to our 3.x milestone, so when we begin preparing for a major release, this won't be forgotten.

@pierresh
Copy link

pierresh commented Sep 14, 2022

I comment Device.uuid = getUuid(); public void initialize(CordovaInterface cordova, CordovaWebView webView) { super.initialize(cordova, webView); // Device.uuid = getUuid(); }

Thanks a lot for your message, I confirm it is enough to pass the Huawei app store's validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants