Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12875: (iOS) Pushes the inappbrowser window to a higher UI level then the existing… #284

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

maltenorstroem
Copy link
Contributor

@maltenorstroem maltenorstroem commented Aug 20, 2018

… app's window

Platforms affected

iOS

What does this PR do?

Pushes the inappbrowser window to a higher UI leven then the existing app's window. Fix for CB-12875: (ios) Magnifiying glass is showing wrong content with inappbrowser window #251

What testing has been done on this change?

Tested on device (iOS 9.0, 10.2, 11.4) and simulator.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@janpio
Copy link
Member

janpio commented Aug 20, 2018

Are there any possible other side effects of this?
Behavior someone might rely on that changes?

@maltenorstroem
Copy link
Contributor Author

In my opinion, this is a simple correction of the already created PR. The underlying window level is respected.

@shazron
Copy link
Member

shazron commented Aug 21, 2018

I see a failed build for MS Edge on Travis CI. I've tried multiple times restarting it, but it still fails. Looking at other PRs there seems to be general flakiness with browser builds.

Besides that, the PR LGTM

@janpio
Copy link
Member

janpio commented Aug 21, 2018

🥇 Thanks for your first merged PR @maltenorstroem! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants