iOS CDVWKInAppBrowser evaluateJavascript method randomly gets blocked on ios 12

[jonathanli2]

Platforms affected

iOS

What does this PR do?

fix issue #340 iOS CDVWKInAppBrowser evaluateJavascript method randomly gets blocked on iOS 12

What testing has been done on this change?

manual testing

Checklist

• Reported an issue in the JIRA database
• Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
• Added automated test coverage as appropriate for this change.

[jonathanli2]

This is a blocking issue, could we review and merge the change soon?

Thanks
Jonathan

[janpio]

Will this also work in older iOS versions <12?

[dpa99c]

@janpio yes, WKWebView's evaluateJavascript and the associated addScriptMessageHandler used to return the async result via the postMessage API have both been present since iOS 8.

The changes in the PR by @jonathanli2 simply remove the redundant return of the synchronous result which is never used in the WKWebView implementation (my bad for not removing it originally).

[janpio]

Thanks, I don't really know enough about iOS and Obj-C to make decisions like this merge myself - but as it's "your code" I went ahead @dpa99c :)