Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): remove unused replace parameter #410

Merged
merged 1 commit into from
Jan 29, 2019
Merged

fix(typescript): remove unused replace parameter #410

merged 1 commit into from
Jan 29, 2019

Conversation

timbru31
Copy link
Member

This closes #295

Platforms affected

  • n/a (development with TypeScript)

What does this PR do?

Removes the unused replace parameter from the typings.

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@janpio janpio merged commit 6db2f2d into apache:master Jan 29, 2019
@janpio
Copy link
Member

janpio commented Jan 29, 2019

Thanks 👍

@timbru31 timbru31 deleted the patch-1 branch January 29, 2019 21:55
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No description for "replace?" parameter
2 participants
@timbru31 @janpio