Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api.js doesn't follow PlatformRequirements.md #9

Open
janpio opened this issue May 3, 2019 · 0 comments
Open

Api.js doesn't follow PlatformRequirements.md #9

janpio opened this issue May 3, 2019 · 0 comments

Comments

@janpio
Copy link
Member

janpio commented May 3, 2019

https://github.com/apache/cordova-test-platform/blob/master/src/cordova/Api.js vs. https://github.com/apache/cordova-test-platform/blob/master/PlatformRequirements.md

Api.prototype.requirements = function() {
events.emit('log', "test-platform:Api:requirements");
return true;
};

vs.

https://github.com/apache/cordova-test-platform/blob/master/PlatformRequirements.md#platformapiprototyperequirements--function-

The .requirements must return a promise, resolved with a set of Requirement objects for the current platform.

Returns true

Api.prototype.run = function(runOptions) {
events.emit('log', "test-platform:Api:run");
};

vs

https://github.com/apache/cordova-test-platform/blob/master/PlatformRequirements.md#platformapiprototyperun--functionrunoptions-

.run must return a promise either fulfilled if the package was build and ran successfully, or rejected with a CordovaError.

Returns nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant