Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugins] Distribute better .gitattributes file to all repos #134

Open
janpio opened this issue Jun 28, 2019 · 1 comment
Open

[Plugins] Distribute better .gitattributes file to all repos #134

janpio opened this issue Jun 28, 2019 · 1 comment
Labels

Comments

@janpio
Copy link
Member

janpio commented Jun 28, 2019

Seems a minimal .gitattributes might not be such a good idea:

* text eol=lf

This can also cause edits to clearly binary files, otherwise as expected git is not smart enough to know that .png for example should keep its line ending.

This seems to be a better file:

* text eol=lf

#
## These files are binary and should be left untouched
#

# (binary is a macro for -text -diff)
*.png binary
*.jpg binary
*.jpeg binary
*.gif binary
*.ico binary
*.mov binary
*.mp4 binary
*.mp3 binary
*.flv binary
*.fla binary
*.swf binary
*.gz binary
*.zip binary
*.7z binary
*.ttf binary
*.eot binary
*.woff binary
*.pyc binary
*.pdf binary

Some projects even have a list of explicitly text files that should be touched, but I can't imagine that this is also necessary: https://github.com/apache/cordova-ios/blob/master/.gitattributes

@janpio janpio added the plugins label Jun 28, 2019
@janpio
Copy link
Member Author

janpio commented Jun 28, 2019

Some plugins are still completely missing this file, so this will also be covered:
https://github.com/apache/cordova-plugin-vibration
https://github.com/apache/cordova-plugin-splashscreen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant