Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define how Cordova handles package-lock.json #3

Closed
janpio opened this issue Sep 6, 2018 · 7 comments
Closed

Define how Cordova handles package-lock.json #3

janpio opened this issue Sep 6, 2018 · 7 comments

Comments

@janpio
Copy link
Member

janpio commented Sep 6, 2018

npm introduced package-lock.json some time ago. Apache Cordova never decided how this file should be handled in our packages (commit to git? not commit to git? .gitignore?).

We should define that and make the necessary changes.

@raphinesse
Copy link
Contributor

I thought we decided to commit it some time ago. It's on the ToDos for the next major.

@janpio
Copy link
Member Author

janpio commented Sep 6, 2018

Well, then there should be an issue here to track the progress.

(Creating that issue now)

@janpio janpio closed this as completed Sep 6, 2018
@raphinesse
Copy link
Contributor

raphinesse commented Sep 6, 2018

It's in "planned" on the board for the next major.

So do we put meta issues here now?

@janpio
Copy link
Member Author

janpio commented Sep 6, 2018

Yep, those "cards" should be converted to issues anyway (at least that's how I understood @erisu's intent - please correct me if I'm wrong) - and here is the only place that matches.

@janpio janpio mentioned this issue Sep 6, 2018
39 tasks
@janpio
Copy link
Member Author

janpio commented Sep 6, 2018

The card has now been converted to an issue.
Should have checked the board first before creating this issue, but well...

@erisu
Copy link
Member

erisu commented Sep 6, 2018

Yes, all note cards needs to be converted into issues. I was not confident in which repo these issues were to be created. If we decided this repo then I can go head and start converting them all.

All items on that board, especially in the planned column, was decided for this coming next major.

The items in the planning/ideas column might need more discussion but the title and content can be written as if its an actual task that will be implemented but add the discussion label.

Once moved to the planned column, we can remove the discussion label.

@janpio @raphinesse

Sorry I hadn't had time to send out an official email to the mailing list or bing up any of these questions.

@brodycj
Copy link

brodycj commented Sep 12, 2018

FYI we had already reached agreement in [1], would have liked a cross-reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants