Skip to content

Commit 31c3c6e

Browse files
committed
Enable ABS tests in legacy/ANSI mode
1 parent d497aba commit 31c3c6e

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1385,8 +1385,7 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
13851385
testDoubleScalarExpr("expm1")
13861386
}
13871387

1388-
// https://github.com/apache/datafusion-comet/issues/666
1389-
ignore("abs") {
1388+
test("abs") {
13901389
Seq(true, false).foreach { dictionaryEnabled =>
13911390
withTempDir { dir =>
13921391
val path = new Path(dir.toURI.toString, "test.parquet")
@@ -1400,8 +1399,7 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
14001399
}
14011400
}
14021401

1403-
// https://github.com/apache/datafusion-comet/issues/666
1404-
ignore("abs Overflow ansi mode") {
1402+
test("abs Overflow ANSI mode") {
14051403

14061404
def testAbsAnsiOverflow[T <: Product: ClassTag: TypeTag](data: Seq[T]): Unit = {
14071405
withParquetTable(data, "tbl") {
@@ -1434,8 +1432,7 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
14341432
}
14351433
}
14361434

1437-
// https://github.com/apache/datafusion-comet/issues/666
1438-
ignore("abs Overflow legacy mode") {
1435+
test("abs Overflow legacy mode") {
14391436

14401437
def testAbsLegacyOverflow[T <: Product: ClassTag: TypeTag](data: Seq[T]): Unit = {
14411438
withSQLConf(SQLConf.ANSI_ENABLED.key -> "false") {

spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -504,10 +504,10 @@ abstract class CometTestBase
504504
| optional float _6;
505505
| optional double _7;
506506
| optional binary _8(UTF8);
507-
| optional int32 _9(UINT_8);
508-
| optional int32 _10(UINT_16);
509-
| optional int32 _11(UINT_32);
510-
| optional int64 _12(UINT_64);
507+
| optional int32 _9(INT_8);
508+
| optional int32 _10(INT_16);
509+
| optional int32 _11(INT_32);
510+
| optional int64 _12(INT_64);
511511
| optional binary _13(ENUM);
512512
| optional FIXED_LEN_BYTE_ARRAY(3) _14;
513513
| optional int32 _15(DECIMAL(5, 2));

0 commit comments

Comments
 (0)