Skip to content

Commit 5fb88b8

Browse files
authored
feat: Define function signatures in CometFuzz (#2614)
1 parent 00922cf commit 5fb88b8

File tree

5 files changed

+548
-135
lines changed

5 files changed

+548
-135
lines changed

fuzz-testing/README.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ Set appropriate values for `SPARK_HOME`, `SPARK_MASTER`, and `COMET_JAR` environ
6161
$SPARK_HOME/bin/spark-submit \
6262
--master $SPARK_MASTER \
6363
--class org.apache.comet.fuzz.Main \
64-
target/comet-fuzz-spark3.4_2.12-0.7.0-SNAPSHOT-jar-with-dependencies.jar \
64+
target/comet-fuzz-spark3.5_2.12-0.12.0-SNAPSHOT-jar-with-dependencies.jar \
6565
data --num-files=2 --num-rows=200 --exclude-negative-zero --generate-arrays --generate-structs --generate-maps
6666
```
6767

@@ -77,7 +77,7 @@ Generate random queries that are based on the available test files.
7777
$SPARK_HOME/bin/spark-submit \
7878
--master $SPARK_MASTER \
7979
--class org.apache.comet.fuzz.Main \
80-
target/comet-fuzz-spark3.4_2.12-0.7.0-SNAPSHOT-jar-with-dependencies.jar \
80+
target/comet-fuzz-spark3.5_2.12-0.12.0-SNAPSHOT-jar-with-dependencies.jar \
8181
queries --num-files=2 --num-queries=500
8282
```
8383

@@ -88,18 +88,17 @@ Note that the output filename is currently hard-coded as `queries.sql`
8888
```shell
8989
$SPARK_HOME/bin/spark-submit \
9090
--master $SPARK_MASTER \
91+
--conf spark.memory.offHeap.enabled=true \
92+
--conf spark.memory.offHeap.size=16G \
9193
--conf spark.plugins=org.apache.spark.CometPlugin \
9294
--conf spark.comet.enabled=true \
93-
--conf spark.comet.exec.enabled=true \
94-
--conf spark.comet.exec.all.enabled=true \
9595
--conf spark.shuffle.manager=org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager \
9696
--conf spark.comet.exec.shuffle.enabled=true \
97-
--conf spark.comet.exec.shuffle.mode=auto \
9897
--jars $COMET_JAR \
9998
--conf spark.driver.extraClassPath=$COMET_JAR \
10099
--conf spark.executor.extraClassPath=$COMET_JAR \
101100
--class org.apache.comet.fuzz.Main \
102-
target/comet-fuzz-spark3.4_2.12-0.7.0-SNAPSHOT-jar-with-dependencies.jar \
101+
target/comet-fuzz-spark3.5_2.12-0.12.0-SNAPSHOT-jar-with-dependencies.jar \
103102
run --num-files=2 --filename=queries.sql
104103
```
105104

fuzz-testing/src/main/scala/org/apache/comet/fuzz/Main.scala

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,11 @@ object Main {
8787
SchemaGenOptions(
8888
generateArray = conf.generateData.generateArrays(),
8989
generateStruct = conf.generateData.generateStructs(),
90-
generateMap = conf.generateData.generateMaps()),
90+
generateMap = conf.generateData.generateMaps(),
91+
// create two columns of each primitive type so that they can be used in binary
92+
// expressions such as `a + b` and `a < b`
93+
primitiveTypes = SchemaGenOptions.defaultPrimitiveTypes ++
94+
SchemaGenOptions.defaultPrimitiveTypes),
9195
DataGenOptions(
9296
allowNull = true,
9397
generateNegativeZero = !conf.generateData.excludeNegativeZero()))

0 commit comments

Comments
 (0)