Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CometNativeExec.doCanonicalize should canonicalize SparkPlan in Product parameters #448

Closed
viirya opened this issue May 18, 2024 · 0 comments · Fixed by #447
Closed

CometNativeExec.doCanonicalize should canonicalize SparkPlan in Product parameters #448

viirya opened this issue May 18, 2024 · 0 comments · Fixed by #447
Labels
bug Something isn't working

Comments

@viirya
Copy link
Member

viirya commented May 18, 2024

Describe the bug

SparkPlan.doCanonicalize default implementation canonicalizes expressions in Product parameters, but not for SparkPlan because derived classes in Spark doesn't have such parameters.

However, CometNativeExec classes might have SparkPlan in their Product parameters. The difference makes some Comet query plan cannot be reused by `ReuseExchangeAndSubquery.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix CometNativeExec.doCanonicalize for ReusedExchangeExec viirya/arrow-datafusion-comet
1 participant
@viirya