Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CometShuffleManager to adapt IndexShuffleBlockResolver signature change #609

Closed
kazuyukitanimura opened this issue Jun 28, 2024 · 2 comments · Fixed by #610
Closed
Assignees
Labels
bug Something isn't working

Comments

@kazuyukitanimura
Copy link
Contributor

Describe the bug

The head of Spark 3.4 branch changed the signature of IndexShuffleBlockResolver constructor compared to v3.4.1
In particular val taskIdMapsForShuffle: JMap[Int, OpenHashSet[Long]] = Collections.emptyMap() is added as 3rd argument that creates binary compatibility issue.

Steps to reproduce

Use latest snapshot of Spark 3.4

Expected behavior

No response

Additional context

No response

@kazuyukitanimura kazuyukitanimura added the bug Something isn't working label Jun 28, 2024
@kazuyukitanimura
Copy link
Contributor Author

If this one merged apache/spark#47148, we can close this one

@viirya
Copy link
Member

viirya commented Jun 29, 2024

That Spark PR is targeting the master branch, how does it do with Spark 3.4?

In any way, I think it is only an issue once you use Spark 3.4 with that signature change and Comet built with older Spark 3.4 without the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants