Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the Supported Input Data Type #64

Closed
jinwenjie123 opened this issue Feb 20, 2024 · 6 comments
Closed

What's the Supported Input Data Type #64

jinwenjie123 opened this issue Feb 20, 2024 · 6 comments
Labels
question Further information is requested

Comments

@jinwenjie123
Copy link

jinwenjie123 commented Feb 20, 2024

What is the problem the feature request solves?

Hi Team,

I am wondering will we have a documentation about what kinda of data types are supported by Comet/Datafusion (Like, Decimal(16, 6), interger .... ) and will not fallback to vanilla spark and cause the regression.

Or where I can lookup to find related information. Since this is very important while we are trying to evaluate whether to use Comet or not.

Thank you so much !

Describe the potential solution

No response

Additional context

No response

@jinwenjie123 jinwenjie123 added the enhancement New feature or request label Feb 20, 2024
@jinwenjie123 jinwenjie123 changed the title Supported Input Data Type What's the Supported Input Data Type Feb 20, 2024
@viirya
Copy link
Member

viirya commented Feb 20, 2024

We will add the document, maybe as part of user document in #57.

For a quick answer, primitive types should be supported now: ByteType, ShortType, IntegerType, LongType, FloatType, DoubleType, StringType, BinaryType, TimestampType, DecimalType, DateType, BooleanType, NullType. The support I mean is, Comet query planner will accept query plan using these types. But for certain expression or operator, the supported types might be various, for example, if the corresponding DataFusion expression or operator may not support some data types.

I think one important goal of Comet is to fulfill the gap and we are working on it. So welcome to report any missing datatypes when you test or evaluate Comet.

@jinwenjie123
Copy link
Author

Thank you !

One more quick question. Is Decimal(26, 6) currently supported ?

@viirya
Copy link
Member

viirya commented Feb 20, 2024

DecimalType is supported.

@sunchao sunchao added question Further information is requested and removed enhancement New feature or request labels Feb 21, 2024
@sunchao
Copy link
Member

sunchao commented Feb 21, 2024

We should support all primitive data types as of now (if not, we should definitely fill the gap).

Complex types (e.g., list, map, struct) are not supported in the Parquet scan. We do have plan to support it soon.

@viirya
Copy link
Member

viirya commented May 6, 2024

We have better documentation for the issue: https://datafusion.apache.org/comet/user-guide/datatypes.html

@viirya viirya closed this as completed May 6, 2024
@viirya
Copy link
Member

viirya commented May 6, 2024

Close it now. Please let me know if you still have other questions. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants