Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substrait Rust Feature #526

Closed
jdye64 opened this issue Oct 26, 2023 · 0 comments · Fixed by #527
Closed

Substrait Rust Feature #526

jdye64 opened this issue Oct 26, 2023 · 0 comments · Fixed by #527
Labels
enhancement New feature or request

Comments

@jdye64
Copy link
Contributor

jdye64 commented Oct 26, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
While currently it is possible to use the protoc feature in ADP that simply attempts to compile protobuf-src and use the resulting binary to compile the protobuf definition files needed by the substrait module. However, in certain conda environments there are situations where the appropriate system libraries are not available for protobuf-src to successfully compile. Therefore I think it makes sense to make a substrait feature that would make the substrait module optional for these cases.

Describe the solution you'd like
Add a new substrait feature to Cargo.toml which when specified would compile the substrait module. Default would be to not include the substrait module.

Describe alternatives you've considered
None

Additional context
None

@jdye64 jdye64 added the enhancement New feature or request label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant