Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate aliases #774

Closed
timsaucer opened this issue Jul 25, 2024 · 0 comments · Fixed by #771
Closed

Remove duplicate aliases #774

timsaucer opened this issue Jul 25, 2024 · 0 comments · Fixed by #771
Labels
bug Something isn't working

Comments

@timsaucer
Copy link
Contributor

Describe the bug

We have places in the rust code where aliases are defined but not used now that we have the python wrappers. For example, the function array_append has the following aliases defined in functions.rs: array_push_back, list_append, and list_push_back. These are not being used in the python wrappers, which do their aliases themselves.

We should remove these pieces of duplicate code.

To Reproduce
This doesn't cause any degraded performance except bloat of the distributed files.

Expected behavior
We should not have duplicate aliases.

Additional context

@timsaucer timsaucer added the bug Something isn't working label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant