condition on debug_assertions instead of FF

it's a bit of FF misuse

Author: findepi

Cargo.lock

@@ -233,12 +233,13 @@ impl ScalarUDF {
     ///
     /// See [`ScalarUDFImpl::invoke_with_args`] for details.
     pub fn invoke_with_args(&self, args: ScalarFunctionArgs) -> Result<ColumnarValue> {
-        #[cfg(feature = "integration-tests")]
+        #[cfg(debug_assertions)]
         let return_field = Arc::clone(&args.return_field);
         match self.inner.invoke_with_args(args) {
             Ok(value) => {
                 // Maybe this could be enabled always?
-                #[cfg(feature = "integration-tests")]
+                // This doesn't use debug_assert!, but it's meant to run anywhere except on production, so it's same in spirit, so conditioning on debug_assertions.
+                #[cfg(debug_assertions)]
                 if &value.data_type() != return_field.data_type() {
                     return datafusion_common::exec_err!("Function '{}' returned value of type '{:?}' while the following type was promised at planning time and expected: '{:?}'",
                         self.name(),

datafusion/expr/src/udf.rs

@@ -44,8 +44,6 @@ bytes = { workspace = true, optional = true }
 chrono = { workspace = true, optional = true }
 clap = { version = "4.5.47", features = ["derive", "env"] }
 datafusion = { workspace = true, default-features = true, features = ["avro", "parquet_encryption"] }
-# integration-tests feature enables additional assertions within the production code
-datafusion-expr = { workspace = true, features = ["integration-tests"] }
 datafusion-spark = { workspace = true, default-features = true }
 datafusion-substrait = { workspace = true, default-features = true }
 futures = { workspace = true }