Minor clean ups

Author: eejbyfeldt

datafusion/core/tests/fuzz_cases/join_fuzz.rs

@@ -243,7 +243,7 @@ async fn test_left_mark_join_1k() {
         JoinType::LeftMark,
         None,
     )
-    .run_test(&[JoinTestType::HjSmj, JoinTestType::NljHj], true)
+    .run_test(&[JoinTestType::HjSmj, JoinTestType::NljHj], false)
     .await
 }
 
@@ -255,7 +255,7 @@ async fn test_left_mark_join_1k_filtered() {
         JoinType::LeftMark,
         Some(Box::new(col_lt_col_filter)),
     )
-    .run_test(&[JoinTestType::HjSmj, JoinTestType::NljHj], true)
+    .run_test(&[JoinTestType::HjSmj, JoinTestType::NljHj], false)
     .await
 }
 

datafusion/expr/src/logical_plan/builder.rs

@@ -1333,7 +1333,7 @@ fn mark_field(schema: &DFSchema) -> (Option<TableReference>, Arc<Field>) {
         .collect::<Vec<_>>();
     table_references.dedup();
     let table_reference = if table_references.len() == 1 {
-        table_references.first().cloned().cloned()
+        table_references.pop().cloned()
     } else {
         None
     };

datafusion/physical-plan/src/joins/utils.rs

@@ -1264,7 +1264,7 @@ pub(crate) fn build_batch_from_indices(
 
     for column_index in column_indices {
         let array = if column_index.side == JoinSide::None {
-            // LeftMark join, the mark column is a boolean if the indices is not null
+            // LeftMark join, the mark column is a true if the indices is not null, otherwise it will be false
             Arc::new(compute::is_not_null(probe_indices)?)
         } else if column_index.side == build_side {
             let array = build_input_buffer.column(column_index.index);