Skip to content

Commit d478598

Browse files
committed
chore: Address PR comments
1 parent 9db0da4 commit d478598

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

datafusion/physical-expr/src/utils/mod.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -253,10 +253,7 @@ pub fn reassign_expr_columns(
253253
) -> Result<Arc<dyn PhysicalExpr>> {
254254
expr.transform_down(|expr| {
255255
if let Some(column) = expr.as_any().downcast_ref::<Column>() {
256-
let index = match schema.index_of(column.name()) {
257-
Ok(idx) => idx,
258-
Err(e) => return Err(e.into()),
259-
};
256+
let index = schema.index_of(column.name())?;
260257

261258
return Ok(Transformed::yes(Arc::new(Column::new(
262259
column.name(),

datafusion/physical-plan/src/filter.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,11 @@ impl RecordBatchStream for FilterExecStream {
716716
}
717717

718718
/// Return the equals Column-Pairs and Non-equals Column-Pairs
719-
fn collect_columns_from_predicate(
719+
#[deprecated(
720+
since = "51.0.0",
721+
note = "This function will be internal in the future"
722+
)]
723+
pub fn collect_columns_from_predicate(
720724
predicate: &'_ Arc<dyn PhysicalExpr>,
721725
) -> EqualAndNonEqual<'_> {
722726
let mut eq_predicate_columns = Vec::<PhysicalExprPairRef>::new();

0 commit comments

Comments
 (0)