-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SortMergeJoin: Add fuzz tests for SMJ when the JoinFilter is set #10659
Labels
enhancement
New feature or request
Comments
This was referenced May 24, 2024
@edmondop I'd suggest to make one step a time. join filter can be tricky, my vision we should be starting with HJ and SMJ for now. Leave NLJ for later |
Ok I will proceed to remove the join filter on the nested loop ! |
Appreciate if you could file the issue cc'ing me with NLJ wrong behavior details |
RightJoin and LeftAnti join will addressed in separate PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem or challenge?
SMJ now is in experimental state, and the test coverage can be improved. Because of poor test coverage it was found multiple bugs manually, with tests it would be much easier
Describe the solution you'd like
I would like to expand fuzz test coverage for SMJ in
join_fuzz.rs
to support scenarios when the JoinFilter is set.datafusion/datafusion/core/tests/fuzz_cases/join_fuzz.rs
Line 179 in 8bedecc
Currently JoinFilter is hardcoded as None for SMJ and would be great to start work for adding filter test cases
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: