Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SortMergeJoin: Add fuzz tests for SMJ when the JoinFilter is set #10659

Closed
Tracked by #9846
comphead opened this issue May 24, 2024 · 6 comments · Fixed by #13369
Closed
Tracked by #9846

SortMergeJoin: Add fuzz tests for SMJ when the JoinFilter is set #10659

comphead opened this issue May 24, 2024 · 6 comments · Fixed by #13369
Labels
enhancement New feature or request

Comments

@comphead
Copy link
Contributor

comphead commented May 24, 2024

Is your feature request related to a problem or challenge?

SMJ now is in experimental state, and the test coverage can be improved. Because of poor test coverage it was found multiple bugs manually, with tests it would be much easier

Describe the solution you'd like

I would like to expand fuzz test coverage for SMJ in join_fuzz.rs to support scenarios when the JoinFilter is set.

Currently JoinFilter is hardcoded as None for SMJ and would be great to start work for adding filter test cases

Describe alternatives you've considered

No response

Additional context

No response

@edmondop
Copy link
Contributor

@comphead would you please have a look at #10728? While hashjoin and sortmergejoin produce the same result when adding a filter, NestedLoopJoin doesn't, but I can't figure out what error I made in combining the two filters

@comphead
Copy link
Contributor Author

comphead commented Jun 3, 2024

@edmondop I'd suggest to make one step a time. join filter can be tricky, my vision we should be starting with HJ and SMJ for now. Leave NLJ for later

@edmondop
Copy link
Contributor

edmondop commented Jun 3, 2024

Ok I will proceed to remove the join filter on the nested loop !

@comphead
Copy link
Contributor Author

comphead commented Jun 3, 2024

Appreciate if you could file the issue cc'ing me with NLJ wrong behavior details

@edmondop
Copy link
Contributor

edmondop commented Jun 4, 2024

@comphead I filed this #10787, I have only added one test case with filtering at the moment, do you think we need to add one test case with filtering for each of the existing test cases?

@comphead
Copy link
Contributor Author

RightJoin and LeftAnti join will addressed in separate PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants