Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NullState::is_null public method #11591

Open
joroKr21 opened this issue Jul 22, 2024 · 0 comments
Open

Add NullState::is_null public method #11591

joroKr21 opened this issue Jul 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@joroKr21
Copy link
Contributor

Is your feature request related to a problem or challenge?

For some group accumulators it would be necessary to check if the previous value was null explicitly. E.g. consider implementing GroupsAccumulator for FirstValue. One could explicitly store the null state of all groups but if we already use NullState it would make sense to reuse it for null checking as well.

Describe the solution you'd like

Add a public NullState::is_null method that takes and index and returns bool.

Describe alternatives you've considered

The alternative is to store a duplicate null state (e.g. as a NullBufferBuilder) in the groups accumulator but that is more wasteful.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant