Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[substrait] add support for Substrait Relation emit kind #12347

Closed
vbarua opened this issue Sep 5, 2024 · 1 comment · Fixed by #13127
Closed

[substrait] add support for Substrait Relation emit kind #12347

vbarua opened this issue Sep 5, 2024 · 1 comment · Fixed by #13127
Assignees
Labels
enhancement New feature or request

Comments

@vbarua
Copy link
Contributor

vbarua commented Sep 5, 2024

Is your feature request related to a problem or challenge?

Substrait relations have the concept of an emit kind, which can either be:

  • Direct: which is the default order and outputs fields based on the Direct Output Order specified in the Substrait spec.
  • Emit: which includes a list of the outputs to include based on the Direct output ordering.

Currently, DataFusion ignores the emit_kind field entirely, which can impact the correctness of Substrait plan execution.

For more details see https://substrait.io/relations/basics/#emit-output-ordering

Describe the solution you'd like

DataFusion should handle both Direct and Emit emit kinds.

Describe alternatives you've considered

No response

Additional context

No response

@vbarua vbarua added the enhancement New feature or request label Sep 5, 2024
@vbarua
Copy link
Contributor Author

vbarua commented Sep 5, 2024

take

@vbarua vbarua changed the title [Substrait] add support for Substrait emitKind [substrait] add support for Substrait Relation emit kind Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant