Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[substrait] handle AggregateRel grouping_expressions field #12957

Closed
vbarua opened this issue Oct 15, 2024 · 1 comment · Fixed by #13173
Closed

[substrait] handle AggregateRel grouping_expressions field #12957

vbarua opened this issue Oct 15, 2024 · 1 comment · Fixed by #13173
Assignees
@akoshchiy
Labels
enhancement New feature or request

Comments

@vbarua
Copy link
Contributor

vbarua commented Oct 15, 2024

Is your feature request related to a problem or challenge?

#12863 updated DataFusion with changes from Substrait 0.58.0

The Substrait changes included substrait-io/substrait#706, which added a new grouping_expressions field to the AggregateRel.

Describe the solution you'd like

DataFusion should be updated to correctly read and write this new field, in line with the updated spec.

Describe alternatives you've considered

No response

Additional context

No response
@vbarua vbarua added the enhancement New feature or request label Oct 15, 2024
@vbarua vbarua mentioned this issue Oct 15, 2024
Merged
@vbarua vbarua changed the title [substrait] handle [substrait] handle AggregateRel grouping_expressions field Oct 15, 2024
@akoshchiy
Copy link
Contributor

take

@akoshchiy akoshchiy mentioned this issue Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akoshchiy akoshchiy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(substrait): AggregateRel grouping_expressions support akoshchiy/arrow-datafusion
2 participants
@akoshchiy @vbarua