Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sqllogictest to extract postgres functionality into a separate file #13948

Closed
Tracked by #13811
Omega359 opened this issue Dec 30, 2024 · 2 comments · Fixed by #13971
Closed
Tracked by #13811

Refactor sqllogictest to extract postgres functionality into a separate file #13948

Omega359 opened this issue Dec 30, 2024 · 2 comments · Fixed by #13971
Assignees
Labels
enhancement New feature or request

Comments

@Omega359
Copy link
Contributor

Is your feature request related to a problem or challenge?

As mentioned in #13936 (comment) as part of #13936 the implementation of sqllogictest.rs with the sqlite changes has resulted in a file with far too many #[cfg(feature = "postgres")] and should be refactored to extract out the postgresql functionality to a separate file.

Describe the solution you'd like

A new file postgres_container.rs is added which contains the postgresql functionality formerly in the sqllogictest.rs file

Describe alternatives you've considered

No response

Additional context

No response

@Omega359
Copy link
Contributor Author

take

@Omega359
Copy link
Contributor Author

This is ready to go but I'll wait for #13936 to be merged before creating a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant