refactor(hash_join): Move JoinHashMap to separate mod #15419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctsk
force-pushed
the
refactor/join_hash_map
branch
from
b3623b4 to
cd8f90c
Compare
Weijun-H
reviewed
Mar 25, 2025
Weijun-H
approved these changes
Mar 25, 2025
Co-authored-by: Alex Huang <huangweijun1001@gmail.com>
|
Looks good to me too -- thank you @ctsk and @Weijun-H FYI @comphead and @Dandandan |
|
🚀 |
qstommyshu
pushed a commit
to qstommyshu/datafusion
that referenced
this pull request
Mar 27, 2025
* refactor(hash_join): Move JoinHashMap to separate mod * Add description to join_hash_map module Co-authored-by: Alex Huang <huangweijun1001@gmail.com> --------- Co-authored-by: Alex Huang <huangweijun1001@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
JoinHashMapimplementation is a large part of thejoins::utilsmodule and fully self-contained. I think it makes sense to make it its own module.What changes are included in this PR?
JoinHashMapinto its own moduleJoinHashMapandJoinHashMapTypefromjoins::utilsfor backwards compatibilityAre these changes tested?
Covered by existing tests.
Are there any user-facing changes?
No.