Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent memory tracking for SortExec #2155

Closed
yjshen opened this issue Apr 4, 2022 · 0 comments · Fixed by #2135
Closed

Inconsistent memory tracking for SortExec #2155

yjshen opened this issue Apr 4, 2022 · 0 comments · Fixed by #2135
Labels
bug Something isn't working

Comments

@yjshen
Copy link
Member

yjshen commented Apr 4, 2022

Describe the bug

We have moved requesters' memory tracking method in #1691:

Consumers push their memory usage to MemoryManager. No more pull from MemoryManagers for usage updates.

Inconsistency memory tracking exists for SortExec, which may cause incorrect total memory accounting in the memory manager, and potentially block other requesters' running when we have more than one requester.
@yjshen yjshen added the bug Something isn't working label Apr 4, 2022
@yjshen yjshen mentioned this issue Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: incorrect memory usage track for sort yjshen/datafusion
1 participant
@yjshen