Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TPCH test schemas to use Decimal128 from Float #3435

Closed
kmitchener opened this issue Sep 10, 2022 · 0 comments · Fixed by #3438
Closed

update TPCH test schemas to use Decimal128 from Float #3435

kmitchener opened this issue Sep 10, 2022 · 0 comments · Fixed by #3438
Labels
enhancement New feature or request

Comments

@kmitchener
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

The TPCH benchmark was updated to use Decimal128 instead of Float in #3393, so the related tests should be updated as well. This is also related to #3395 which is updating SQL literal parsing to use decimals instead of floats. Doing this change separately should make that PR smaller.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant