Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change rule of PreCastLitInComparisonExpressions to unwrap cast rule after #3582 #3622

Closed
liukun4515 opened this issue Sep 27, 2022 · 0 comments · Fixed by #3662
Closed

change rule of PreCastLitInComparisonExpressions to unwrap cast rule after #3582 #3622

liukun4515 opened this issue Sep 27, 2022 · 0 comments · Fixed by #3662
Labels
enhancement New feature or request

Comments

@liukun4515
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

after this #3582 merged, the type coercion will be done before the optimizer.

The PreCastLitInComparisonExpressions will take affect.

For example:

schema: the data type of c is int32
select * from table c > 10;

after done the type coercion, we will get the expr like cast(c as int64) > int64(10) and the PreCastLitInComparisonExpressions will not affect the above expr.

But we can convert the int64(10) to the type of c with unwrap cast the expr cast(c as int64), it is very similar to what spark done https://issues.apache.org/jira/browse/SPARK-32858

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant