Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify division by zero (division by one / multiplication by zero / multiplication by one) for Decimal types as well #3643

Closed
alamb opened this issue Sep 28, 2022 · 1 comment · Fixed by #3782
Closed

Simplify division by zero (division by one / multiplication by zero / multiplication by one) for Decimal types as well #3643

alamb opened this issue Sep 28, 2022 · 1 comment · Fixed by #3782
Labels
good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Sep 28, 2022 •
edited
Loading

@HaoYang670 added the simplification rule to simplify col * 0 for numeric types other than Decimal in #3627

This ticket tracks adding this support for Decimal.

Originally posted by @HaoYang670 in #3627 (comment)
@alamb
Copy link
Contributor Author

alamb commented Sep 28, 2022

Marking as a good first issue as the pattern exists for other types, so a contributor could follow the existing pattern and get a little familiar with the code

@alamb alamb added the good first issue Good for newcomers label Sep 28, 2022
@alamb alamb mentioned this issue Sep 28, 2022
Merged
@HaoYang670 HaoYang670 changed the title Simplify division by zero for Decimal types as well Simplify division by zero (division by one / multiplication by zero / multiplication by one) for Decimal types as well Sep 30, 2022
@drrtuy drrtuy mentioned this issue Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
1 participant
@alamb