Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine GroupByScalar and ScalarValue #376

Closed
alamb opened this issue May 21, 2021 · 1 comment · Fixed by #786
Closed

Combine GroupByScalar and ScalarValue #376

alamb opened this issue May 21, 2021 · 1 comment · Fixed by #786
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented May 21, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
There is non trivial overlap of similar, but not quite the same features in GroupByScalar and ScalarValue

As discussed on #364 (comment) we think this is an historical artifact and the code would be simpler / have fewer bugs if they were combined.

Describe the solution you'd like
COmbine the two classes (into ScalarValue)
@alamb alamb added the enhancement New feature or request label May 21, 2021
@alamb alamb mentioned this issue May 21, 2021
Closed
@alamb alamb mentioned this issue Jul 27, 2021
Merged
@alamb
Copy link
Contributor Author

alamb commented Jul 28, 2021

One thing we have discovered while working on #768 is that the size of GroupByScalar is 16 bytes while ScalarValue is larger (currently 64 bytes but with #788 it could be 32 bytes).

Another difference is that GroupByScalar has no way to represent "NULL" (and thus at the moment hash aggregates also do not support grouping by NULL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@alamb