-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Expr
enum consistent with LogicalPlan
by using structs for each variant
#3807
Comments
I prepare to promote this task. I invite some contributor. |
Hi, I am new to this project. Can I help with |
It's OK, Thank you @SkyFan2002 |
Hello,I‘m a noob to this project and interested in Exists part.May I have a try? |
It's OK, Thank you @QuenKar |
Hi, I'd like to try InSubquery. |
@gitccl welcome, thanks |
I'd like to try AggregateUDF. Thanks. |
Already finish it, thanks everyone!❤️ |
Pretty amazing @jackwener and everyone else who helped out here -- very nice |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
See the discussion at #2175 for background context, but the basic issue is that there are different styles between
LogicalPlan
andExpr
.LogicalPlan
Each variant in LogicalPlan wraps a struct. The structs typically have
try_new
methods with some validation logic.Expr
Expr has a mixed style. Some variants wrap structs and some do not.
Describe the solution you'd like
We would like each variant in
Expr
to wrap a struct (except perhaps for the very simple ones that contain one or two items) and addnew
and/ortry_new
methods to those structs as appropriate.Expr::Case
to use a struct #3757Expr::Like
,Expr::ILike
,Expr::SimilarTo
to use a struct #3836Expr::GetIndexedField
to use a struct #3860Describe alternatives you've considered
Do nothing
Additional context
None
The text was updated successfully, but these errors were encountered: