Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inlining view / dataframes logical plan #3913

Closed
Dandandan opened this issue Oct 20, 2022 · 3 comments · Fixed by #3923
Closed

Support inlining view / dataframes logical plan #3913

Dandandan opened this issue Oct 20, 2022 · 3 comments · Fixed by #3923
Labels
enhancement New feature or request performance Make DataFusion faster

Comments

@Dandandan
Copy link
Contributor

Dandandan commented Oct 20, 2022 •
edited
Loading

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
DataFusion supports filter/limit/projection pushdown for views and dataframes via the tableprovider interface after #3905 . Inlining the LogicalPlan (as an optimization rule) would bring more opportunities for optimizations.

Describe the solution you'd like
Support optimization rule that inlines view and dataframes.
A method could be added to the tableprovider trait that returns a Option<LogicalPlan>. This can be used by an optimization rule (e.g. InlineTableProvider).

Describe alternatives you've considered

Additional context
@Dandandan Dandandan added enhancement New feature or request performance Make DataFusion faster labels Oct 20, 2022
@Dandandan Dandandan changed the title Support inking view / dataframes logical plan Support inlining view / dataframes logical plan Oct 20, 2022
@Dandandan Dandandan mentioned this issue Oct 21, 2022
Merged
@alamb
Copy link
Contributor

alamb commented Oct 21, 2022

I vaguely remember a discussion about this topic though I can't find it again now -- perhaps @HaoYang670 ?

@Dandandan
Copy link
Contributor Author

It was this one #3249

@alamb
Copy link
Contributor

alamb commented Oct 22, 2022

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance Make DataFusion faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support inlining view / dataframes logical plan Dandandan/arrow-datafusion
2 participants
@Dandandan @alamb