Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement serialization for ScalarValue::FixedSizeBinary #3928

Closed
alamb opened this issue Oct 22, 2022 · 3 comments · Fixed by #3943
Closed

Implement serialization for ScalarValue::FixedSizeBinary #3928

alamb opened this issue Oct 22, 2022 · 3 comments · Fixed by #3943
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Oct 22, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

@maxburke's PR added ScalarFixedSizeBinary support: #3911

However, it did not implement the serialization code to send ScalarValue::FixedSizeBinary over the network

Describe the solution you'd like

Fill out the code in datafusion/proto/src/to_proto.rs

            scalar::ScalarValue::FixedSizeBinary(_, _) => {
                return Err(Error::General(
                    "FixedSizeBinary is not yet implemented".to_owned(),
                ))
            }

And add a test for round trip serialization

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@alamb alamb added enhancement New feature or request good first issue Good for newcomers labels Oct 22, 2022
@alamb
Copy link
Contributor Author

alamb commented Oct 22, 2022

Should be a good first issue as there are plenty of other examples to follow along

@retikulum
Copy link
Contributor

It looks interesting. Can you assign it to me?

@alamb
Copy link
Contributor Author

alamb commented Oct 23, 2022

See also- #3612 - the serialization code is a bit of a mess now but hopefully we can get it better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants