Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put common code used for testing code into datafusion/test_utils.rs #3960

Closed
alamb opened this issue Oct 25, 2022 · 0 comments · Fixed by #3961
Closed

Put common code used for testing code into datafusion/test_utils.rs #3960

alamb opened this issue Oct 25, 2022 · 0 comments · Fixed by #3961
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Oct 25, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I want to reuse some code added by @thinkharderdev in #3769 in a new test I want to write, but it is in a benchmark at the moment.

Describe the solution you'd like
Refactor common code used for testing code into datafusion/test_utils.rs

Hopefully this will:

  1. Make it clear that the code is used for testing
  2. Make it more discoverable
  3. Encourage people to put more common code here

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant