You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this would likely be a good first project for someone as there is existing test coverage and should "just" be a matter of changing around some APIs
@tustvold Looks like OrderedFloat also implements Hash and Eq for floats. Hash required for ScalarValue, Eq required for centroids. Do you want to make our own impl for Eq,Hash for f64?
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
DataFusion uses OrderedFloat in various places to order floats, this is different from arrow-rs which makes use of https://doc.rust-lang.org/std/primitive.f32.html#method.total_cmp.
Describe the solution you'd like
Moving away from OrderedFloat will:
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: